Skip to contentSkip to conversation

Change in openvpn[master]: openvpnserv: Factor out the string conversion from GetItfDnsDomains

Openvpn-devel In review flichtenheld (Code Review) 2 participants 8 messages Jan 7 – Jan 24 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1767808679000.Ib517457015b754d59aeb70827c4795aa6154728c@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email

to review the following change.

Change subject: openvpnserv: Factor out the string conversion from GetItfDnsDomains
......................................................................

openvpnserv: Factor out the string conversion from GetItfDnsDomains

Mostly so that we can actually test it. Since that code does some in-place conversions a test would be good.

Change-Id Ib517457015b754d59aeb70827c4795aa6154728c

---
M src/openvpnserv/interactive.c

1 file changed, 101 insertions(+), 71 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/58/1458/1

src/openvpnserv/interactive.c +101 -71
index 8b418ce..f30394a 100644
@@ -2143,6 +2143,106 @@
 }
 
 /**
+ * Convert interface specific domain suffix(es) from comma-separated
+ * string to MULTI_SZ string.
+ *
+ * The \p domains paramter will be set to a MULTI_SZ domains string.
+ * In case of an error \p size is set to 0 and the contents of \p domains
+ * are invalid.
+ * Note that domains are deleted from the string if they match a search domain.
+ *
+ * @param[in]     search_domains  optional list of search domains
+ * @param[in,out] domains         buffer that contains the input comma-separated
+ *                                string and will contain the MULTI_SZ output string
+ * @param[in,out] size            pointer to size of the input string in bytes. Will be
+ *                                set to the size of the string returned, including
+ *                                the terminating zeros or 0.
+ * @param[in]     buf_size        size of the \p domains buffer
+ *
+ * @return LSTATUS NO_ERROR if the domain suffix(es) were read successfully,
+ *         ERROR_FILE_NOT_FOUND if no domain was found for the interface,
+ *         ERROR_MORE_DATA if the list did not fit into the buffer
+ */
+static LSTATUS
+ConvertItfDnsDomains(PCWSTR search_domains, PWSTR domains, PDWORD size, const DWORD buf_size)
+{
+    const DWORD glyph_size = sizeof(*domains);
+    const DWORD buf_len = buf_size / glyph_size;
+
+    /*
+     * Found domain(s), now convert them:
+     *   - prefix each domain with a dot
+     *   - convert comma separated list to MULTI_SZ
+     */
+    PWCHAR pos = domains;
+    while (TRUE)
+    {
+        /* Terminate the domain at the next comma */
+        PWCHAR comma = wcschr(pos, ',');
+        if (comma)
+        {
+            *comma = '\0';
+        }
+
+        DWORD domain_len = (DWORD)wcslen(pos);
+        DWORD domain_size = domain_len * glyph_size;
+        DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
+
+        /* Ignore itf domains which match a pushed search domain */
+        if (ListContainsDomain(search_domains, pos, domain_len))
+        {
+            if (comma)
+            {
+                /* Overwrite the ignored domain with remaining one(s) */
+                memmove(pos, comma + 1, buf_size - converted_size);
+                *size -= domain_size + glyph_size;
+                continue;
+            }
+            else
+            {
+                /* This was the last domain */
+                *pos = '\0';
+                *size -= domain_size;
+                return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
+            }
+        }
+
+        /* Add space for the leading dot */
+        domain_len += 1;
+        domain_size += glyph_size;
+
+        /* Space for the terminating zeros */
+        const DWORD extra_size = 2 * glyph_size;
+
+        /* Check for enough space to convert this domain */
+        if (converted_size + domain_size + extra_size > buf_size)
+        {
+            /* Domain doesn't fit, bad luck if it's the first one */
+            *pos = '\0';
+            *size = converted_size == 0 ? 0 : converted_size + glyph_size;
+            return ERROR_MORE_DATA;
+        }
+
+        /* Prefix domain at pos with the dot */
+        memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
+        domains[buf_len - 1] = '\0';
+        *pos = '.';
+        *size += glyph_size;
+
+        if (!comma)
+        {
+            /* Conversion is done */
+            *(pos + domain_len) = '\0';
+            *size += glyph_size;
+            return NO_ERROR;
+        }
+
+        /* Comma pos is now +1 after adding leading dot */
+        pos = comma + 2;
+    }
+}
+
+/**
  * Return interface specific domain suffix(es)
  *
  * The \p domains paramter will be set to a MULTI_SZ domains string.
@@ -2183,77 +2283,7 @@
         err = RegGetValueW(itf, NULL, values[i], RRF_RT_REG_SZ, NULL, (PBYTE)domains, size);
         if (!err && *size > glyph_size && domains[(*size / glyph_size) - 1] == '\0' && wcschr(domains, '.'))
         {
-            /*
-             * Found domain(s), now convert them:
-             *   - prefix each domain with a dot
-             *   - convert comma separated list to MULTI_SZ
-             */
-            PWCHAR pos = domains;
-            while (TRUE)
-            {
-                /* Terminate the domain at the next comma */
-                PWCHAR comma = wcschr(pos, ',');
-                if (comma)
-                {
-                    *comma = '\0';
-                }
-
-                DWORD domain_len = (DWORD)wcslen(pos);
-                DWORD domain_size = domain_len * glyph_size;
-                DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
-
-                /* Ignore itf domains which match a pushed search domain */
-                if (ListContainsDomain(search_domains, pos, domain_len))
-                {
-                    if (comma)
-                    {
-                        /* Overwrite the ignored domain with remaining one(s) */
-                        memmove(pos, comma + 1, buf_size - converted_size);
-                        *size -= domain_size + glyph_size;
-                        continue;
-                    }
-                    else
-                    {
-                        /* This was the last domain */
-                        *pos = '\0';
-                        *size -= domain_size;
-                        return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
-                    }
-                }
-
-                /* Add space for the leading dot */
-                domain_len += 1;
-                domain_size += glyph_size;
-
-                /* Space for the terminating zeros */
-                const DWORD extra_size = 2 * glyph_size;
-
-                /* Check for enough space to convert this domain */
-                if (converted_size + domain_size + extra_size > buf_size)
-                {
-                    /* Domain doesn't fit, bad luck if it's the first one */
-                    *pos = '\0';
-                    *size = converted_size == 0 ? 0 : converted_size + glyph_size;
-                    return ERROR_MORE_DATA;
-                }
-
-                /* Prefix domain at pos with the dot */
-                memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
-                domains[buf_len - 1] = '\0';
-                *pos = '.';
-                *size += glyph_size;
-
-                if (!comma)
-                {
-                    /* Conversion is done */
-                    *(pos + domain_len) = '\0';
-                    *size += glyph_size;
-                    return NO_ERROR;
-                }
-
-                /* Comma pos is now +1 after adding leading dot */
-                pos = comma + 2;
-            }
+            return ConvertItfDnsDomains(search_domains, domains, size, buf_size);
         }
     }
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib517457015b754d59aeb70827c4795aa6154728c
Gerrit-Change-Number: 1458
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to reexamine a change. Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email

to look at the new patch set (#4).

Change subject: openvpnserv: Factor out the string conversion from GetItfDnsDomains
......................................................................

openvpnserv: Factor out the string conversion from GetItfDnsDomains

Mostly so that we can actually test it. Since that code does some in-place conversions a test would be good.

Change-Id Ib517457015b754d59aeb70827c4795aa6154728c

---
M src/openvpnserv/interactive.c

1 file changed, 101 insertions(+), 72 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/58/1458/4

src/openvpnserv/interactive.c +101 -72
index 8b817ed..00657b0 100644
@@ -2143,6 +2143,106 @@
 }
 
 /**
+ * Convert interface specific domain suffix(es) from comma-separated
+ * string to MULTI_SZ string.
+ *
+ * The \p domains paramter will be set to a MULTI_SZ domains string.
+ * In case of an error \p size is set to 0 and the contents of \p domains
+ * are invalid.
+ * Note that domains are deleted from the string if they match a search domain.
+ *
+ * @param[in]     search_domains  optional list of search domains
+ * @param[in,out] domains         buffer that contains the input comma-separated
+ *                                string and will contain the MULTI_SZ output string
+ * @param[in,out] size            pointer to size of the input string in bytes. Will be
+ *                                set to the size of the string returned, including
+ *                                the terminating zeros or 0.
+ * @param[in]     buf_size        size of the \p domains buffer
+ *
+ * @return LSTATUS NO_ERROR if the domain suffix(es) were read successfully,
+ *         ERROR_FILE_NOT_FOUND if no domain was found for the interface,
+ *         ERROR_MORE_DATA if the list did not fit into the buffer
+ */
+static LSTATUS
+ConvertItfDnsDomains(PCWSTR search_domains, PWSTR domains, PDWORD size, const DWORD buf_size)
+{
+    const DWORD glyph_size = sizeof(*domains);
+    const DWORD buf_len = buf_size / glyph_size;
+
+    /*
+     * Found domain(s), now convert them:
+     *   - prefix each domain with a dot
+     *   - convert comma separated list to MULTI_SZ
+     */
+    PWCHAR pos = domains;
+    while (TRUE)
+    {
+        /* Terminate the domain at the next comma */
+        PWCHAR comma = wcschr(pos, ',');
+        if (comma)
+        {
+            *comma = '\0';
+        }
+
+        DWORD domain_len = (DWORD)wcslen(pos);
+        DWORD domain_size = domain_len * glyph_size;
+        DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
+
+        /* Ignore itf domains which match a pushed search domain */
+        if (ListContainsDomain(search_domains, pos, domain_len))
+        {
+            if (comma)
+            {
+                /* Overwrite the ignored domain with remaining one(s) */
+                memmove(pos, comma + 1, buf_size - converted_size);
+                *size -= domain_size + glyph_size;
+                continue;
+            }
+            else
+            {
+                /* This was the last domain */
+                *pos = '\0';
+                *size -= domain_size;
+                return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
+            }
+        }
+
+        /* Add space for the leading dot */
+        domain_len += 1;
+        domain_size += glyph_size;
+
+        /* Space for the terminating zeros */
+        const DWORD extra_size = 2 * glyph_size;
+
+        /* Check for enough space to convert this domain */
+        if (converted_size + domain_size + extra_size > buf_size)
+        {
+            /* Domain doesn't fit, bad luck if it's the first one */
+            *pos = '\0';
+            *size = converted_size == 0 ? 0 : converted_size + glyph_size;
+            return ERROR_MORE_DATA;
+        }
+
+        /* Prefix domain at pos with the dot */
+        memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
+        domains[buf_len - 1] = '\0';
+        *pos = '.';
+        *size += glyph_size;
+
+        if (!comma)
+        {
+            /* Conversion is done */
+            *(pos + domain_len) = '\0';
+            *size += glyph_size;
+            return NO_ERROR;
+        }
+
+        /* Comma pos is now +1 after adding leading dot */
+        pos = comma + 2;
+    }
+}
+
+/**
  * Return interface specific domain suffix(es)
  *
  * The \p domains paramter will be set to a MULTI_SZ domains string.
@@ -2174,7 +2274,6 @@
     LSTATUS err = ERROR_FILE_NOT_FOUND;
     const DWORD buf_size = *size;
     const DWORD glyph_size = sizeof(*domains);
-    const DWORD buf_len = buf_size / glyph_size;
     PWSTR values[] = { L"SearchList", L"Domain", L"DhcpDomainSearchList", L"DhcpDomain", NULL };
 
     for (int i = 0; values[i]; i++)
@@ -2183,77 +2282,7 @@
         err = RegGetValueW(itf, NULL, values[i], RRF_RT_REG_SZ, NULL, (PBYTE)domains, size);
         if (!err && *size > glyph_size && domains[(*size / glyph_size) - 1] == '\0' && wcschr(domains, '.'))
         {
-            /*
-             * Found domain(s), now convert them:
-             *   - prefix each domain with a dot
-             *   - convert comma separated list to MULTI_SZ
-             */
-            PWCHAR pos = domains;
-            while (TRUE)
-            {
-                /* Terminate the domain at the next comma */
-                PWCHAR comma = wcschr(pos, ',');
-                if (comma)
-                {
-                    *comma = '\0';
-                }
-
-                DWORD domain_len = (DWORD)wcslen(pos);
-                DWORD domain_size = domain_len * glyph_size;
-                DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
-
-                /* Ignore itf domains which match a pushed search domain */
-                if (ListContainsDomain(search_domains, pos, domain_len))
-                {
-                    if (comma)
-                    {
-                        /* Overwrite the ignored domain with remaining one(s) */
-                        memmove(pos, comma + 1, buf_size - converted_size);
-                        *size -= domain_size + glyph_size;
-                        continue;
-                    }
-                    else
-                    {
-                        /* This was the last domain */
-                        *pos = '\0';
-                        *size -= domain_size;
-                        return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
-                    }
-                }
-
-                /* Add space for the leading dot */
-                domain_len += 1;
-                domain_size += glyph_size;
-
-                /* Space for the terminating zeros */
-                const DWORD extra_size = 2 * glyph_size;
-
-                /* Check for enough space to convert this domain */
-                if (converted_size + domain_size + extra_size > buf_size)
-                {
-                    /* Domain doesn't fit, bad luck if it's the first one */
-                    *pos = '\0';
-                    *size = converted_size == 0 ? 0 : converted_size + glyph_size;
-                    return ERROR_MORE_DATA;
-                }
-
-                /* Prefix domain at pos with the dot */
-                memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
-                domains[buf_len - 1] = '\0';
-                *pos = '.';
-                *size += glyph_size;
-
-                if (!comma)
-                {
-                    /* Conversion is done */
-                    *(pos + domain_len) = '\0';
-                    *size += glyph_size;
-                    return NO_ERROR;
-                }
-
-                /* Comma pos is now +1 after adding leading dot */
-                pos = comma + 2;
-            }
+            return ConvertItfDnsDomains(search_domains, domains, size, buf_size);
         }
     }
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib517457015b754d59aeb70827c4795aa6154728c
Gerrit-Change-Number: 1458
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>

#3 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

d12fk has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email )

Change subject: openvpnserv: Factor out the string conversion from GetItfDnsDomains
......................................................................

Patch Set 5: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib517457015b754d59aeb70827c4795aa6154728c
Gerrit-Change-Number: 1458
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: d12fk <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: cron2 <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Mon, 19 Jan 2026 20:49:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

#4 lore raw

PATCH v5 1/1 openvpnserv: Factor out the string conversion from GetItfDnsDomains

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Mostly so that we can actually test it. Since that code does some in-place conversions a test would be good.

Change-Id Ib517457015b754d59aeb70827c4795aa6154728c

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1458
---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1458
This mail reflects revision 5 of this Change.

Acked-by according to Gerrit (reflected above):
Heiko Hund <[email protected]...>

src/openvpnserv/interactive.c +101 -72
index b53207bc..5c00eef 100644
@@ -2143,6 +2143,106 @@
 }
 
 /**
+ * Convert interface specific domain suffix(es) from comma-separated
+ * string to MULTI_SZ string.
+ *
+ * The \p domains paramter will be set to a MULTI_SZ domains string.
+ * In case of an error \p size is set to 0 and the contents of \p domains
+ * are invalid.
+ * Note that domains are deleted from the string if they match a search domain.
+ *
+ * @param[in]     search_domains  optional list of search domains
+ * @param[in,out] domains         buffer that contains the input comma-separated
+ *                                string and will contain the MULTI_SZ output string
+ * @param[in,out] size            pointer to size of the input string in bytes. Will be
+ *                                set to the size of the string returned, including
+ *                                the terminating zeros or 0.
+ * @param[in]     buf_size        size of the \p domains buffer
+ *
+ * @return LSTATUS NO_ERROR if the domain suffix(es) were read successfully,
+ *         ERROR_FILE_NOT_FOUND if no domain was found for the interface,
+ *         ERROR_MORE_DATA if the list did not fit into the buffer
+ */
+static LSTATUS
+ConvertItfDnsDomains(PCWSTR search_domains, PWSTR domains, PDWORD size, const DWORD buf_size)
+{
+    const DWORD glyph_size = sizeof(*domains);
+    const DWORD buf_len = buf_size / glyph_size;
+
+    /*
+     * Found domain(s), now convert them:
+     *   - prefix each domain with a dot
+     *   - convert comma separated list to MULTI_SZ
+     */
+    PWCHAR pos = domains;
+    while (TRUE)
+    {
+        /* Terminate the domain at the next comma */
+        PWCHAR comma = wcschr(pos, ',');
+        if (comma)
+        {
+            *comma = '\0';
+        }
+
+        DWORD domain_len = (DWORD)wcslen(pos);
+        DWORD domain_size = domain_len * glyph_size;
+        DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
+
+        /* Ignore itf domains which match a pushed search domain */
+        if (ListContainsDomain(search_domains, pos, domain_len))
+        {
+            if (comma)
+            {
+                /* Overwrite the ignored domain with remaining one(s) */
+                memmove(pos, comma + 1, buf_size - converted_size);
+                *size -= domain_size + glyph_size;
+                continue;
+            }
+            else
+            {
+                /* This was the last domain */
+                *pos = '\0';
+                *size -= domain_size;
+                return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
+            }
+        }
+
+        /* Add space for the leading dot */
+        domain_len += 1;
+        domain_size += glyph_size;
+
+        /* Space for the terminating zeros */
+        const DWORD extra_size = 2 * glyph_size;
+
+        /* Check for enough space to convert this domain */
+        if (converted_size + domain_size + extra_size > buf_size)
+        {
+            /* Domain doesn't fit, bad luck if it's the first one */
+            *pos = '\0';
+            *size = converted_size == 0 ? 0 : converted_size + glyph_size;
+            return ERROR_MORE_DATA;
+        }
+
+        /* Prefix domain at pos with the dot */
+        memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
+        domains[buf_len - 1] = '\0';
+        *pos = '.';
+        *size += glyph_size;
+
+        if (!comma)
+        {
+            /* Conversion is done */
+            *(pos + domain_len) = '\0';
+            *size += glyph_size;
+            return NO_ERROR;
+        }
+
+        /* Comma pos is now +1 after adding leading dot */
+        pos = comma + 2;
+    }
+}
+
+/**
  * Return interface specific domain suffix(es)
  *
  * The \p domains paramter will be set to a MULTI_SZ domains string.
@@ -2174,7 +2274,6 @@
     LSTATUS err = ERROR_FILE_NOT_FOUND;
     const DWORD buf_size = *size;
     const DWORD glyph_size = sizeof(*domains);
-    const DWORD buf_len = buf_size / glyph_size;
     PWSTR values[] = { L"SearchList", L"Domain", L"DhcpDomainSearchList", L"DhcpDomain", NULL };
 
     for (int i = 0; values[i]; i++)
@@ -2183,77 +2282,7 @@
         err = RegGetValueW(itf, NULL, values[i], RRF_RT_REG_SZ, NULL, (PBYTE)domains, size);
         if (!err && *size > glyph_size && domains[(*size / glyph_size) - 1] == '\0' && wcschr(domains, '.'))
         {
-            /*
-             * Found domain(s), now convert them:
-             *   - prefix each domain with a dot
-             *   - convert comma separated list to MULTI_SZ
-             */
-            PWCHAR pos = domains;
-            while (TRUE)
-            {
-                /* Terminate the domain at the next comma */
-                PWCHAR comma = wcschr(pos, ',');
-                if (comma)
-                {
-                    *comma = '\0';
-                }
-
-                DWORD domain_len = (DWORD)wcslen(pos);
-                DWORD domain_size = domain_len * glyph_size;
-                DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
-
-                /* Ignore itf domains which match a pushed search domain */
-                if (ListContainsDomain(search_domains, pos, domain_len))
-                {
-                    if (comma)
-                    {
-                        /* Overwrite the ignored domain with remaining one(s) */
-                        memmove(pos, comma + 1, buf_size - converted_size);
-                        *size -= domain_size + glyph_size;
-                        continue;
-                    }
-                    else
-                    {
-                        /* This was the last domain */
-                        *pos = '\0';
-                        *size -= domain_size;
-                        return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
-                    }
-                }
-
-                /* Add space for the leading dot */
-                domain_len += 1;
-                domain_size += glyph_size;
-
-                /* Space for the terminating zeros */
-                const DWORD extra_size = 2 * glyph_size;
-
-                /* Check for enough space to convert this domain */
-                if (converted_size + domain_size + extra_size > buf_size)
-                {
-                    /* Domain doesn't fit, bad luck if it's the first one */
-                    *pos = '\0';
-                    *size = converted_size == 0 ? 0 : converted_size + glyph_size;
-                    return ERROR_MORE_DATA;
-                }
-
-                /* Prefix domain at pos with the dot */
-                memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
-                domains[buf_len - 1] = '\0';
-                *pos = '.';
-                *size += glyph_size;
-
-                if (!comma)
-                {
-                    /* Conversion is done */
-                    *(pos + domain_len) = '\0';
-                    *size += glyph_size;
-                    return NO_ERROR;
-                }
-
-                /* Comma pos is now +1 after adding leading dot */
-                pos = comma + 2;
-            }
+            return ConvertItfDnsDomains(search_domains, domains, size, buf_size);
         }
     }
 
#5 lore raw

[Openvpn-devel] [PATCH applied] Re: openvpnserv: Factor out the string conversion from GetItfDnsDomains

This is paving the way to adding a unit test for this slightly convoluted modify-string-in-place function - and as such, highly welcome. ACK from Heiko, green light from the BBs (which do not really test beyond "does it compile with no warnings", but at least that)

"git show --color-moved=zebra -w" is helpful in seeing what exactly got moved (and reindented) and what is new ("the prototype and the explanatory comment").

Your patch has been applied to the master branch.

commit cd533c483aa516a60d12a132761ab349f9b8b399

Author: Frank Lichtenheld
Date:   Mon Jan 19 22:49:22 2026 +0100
     openvpnserv: Factor out the string conversion from GetItfDnsDomains

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Heiko Hund <[email protected]...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1458
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg35343.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#6 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

Hello d12fk, plaisthos,

I'd like you to reexamine a change. Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email

to look at the new patch set (#6).

The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.

Change subject: openvpnserv: Factor out the string conversion from GetItfDnsDomains
......................................................................

openvpnserv: Factor out the string conversion from GetItfDnsDomains

Mostly so that we can actually test it. Since that code does some in-place conversions a test would be good.

Change-Id Ib517457015b754d59aeb70827c4795aa6154728c

---
M src/openvpnserv/interactive.c

1 file changed, 101 insertions(+), 72 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/58/1458/6

src/openvpnserv/interactive.c +101 -72
index b6ab2b8..ad19e2c 100644
@@ -2143,6 +2143,106 @@
 }
 
 /**
+ * Convert interface specific domain suffix(es) from comma-separated
+ * string to MULTI_SZ string.
+ *
+ * The \p domains paramter will be set to a MULTI_SZ domains string.
+ * In case of an error \p size is set to 0 and the contents of \p domains
+ * are invalid.
+ * Note that domains are deleted from the string if they match a search domain.
+ *
+ * @param[in]     search_domains  optional list of search domains
+ * @param[in,out] domains         buffer that contains the input comma-separated
+ *                                string and will contain the MULTI_SZ output string
+ * @param[in,out] size            pointer to size of the input string in bytes. Will be
+ *                                set to the size of the string returned, including
+ *                                the terminating zeros or 0.
+ * @param[in]     buf_size        size of the \p domains buffer
+ *
+ * @return LSTATUS NO_ERROR if the domain suffix(es) were read successfully,
+ *         ERROR_FILE_NOT_FOUND if no domain was found for the interface,
+ *         ERROR_MORE_DATA if the list did not fit into the buffer
+ */
+static LSTATUS
+ConvertItfDnsDomains(PCWSTR search_domains, PWSTR domains, PDWORD size, const DWORD buf_size)
+{
+    const DWORD glyph_size = sizeof(*domains);
+    const DWORD buf_len = buf_size / glyph_size;
+
+    /*
+     * Found domain(s), now convert them:
+     *   - prefix each domain with a dot
+     *   - convert comma separated list to MULTI_SZ
+     */
+    PWCHAR pos = domains;
+    while (TRUE)
+    {
+        /* Terminate the domain at the next comma */
+        PWCHAR comma = wcschr(pos, ',');
+        if (comma)
+        {
+            *comma = '\0';
+        }
+
+        DWORD domain_len = (DWORD)wcslen(pos);
+        DWORD domain_size = domain_len * glyph_size;
+        DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
+
+        /* Ignore itf domains which match a pushed search domain */
+        if (ListContainsDomain(search_domains, pos, domain_len))
+        {
+            if (comma)
+            {
+                /* Overwrite the ignored domain with remaining one(s) */
+                memmove(pos, comma + 1, buf_size - converted_size);
+                *size -= domain_size + glyph_size;
+                continue;
+            }
+            else
+            {
+                /* This was the last domain */
+                *pos = '\0';
+                *size -= domain_size;
+                return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
+            }
+        }
+
+        /* Add space for the leading dot */
+        domain_len += 1;
+        domain_size += glyph_size;
+
+        /* Space for the terminating zeros */
+        const DWORD extra_size = 2 * glyph_size;
+
+        /* Check for enough space to convert this domain */
+        if (converted_size + domain_size + extra_size > buf_size)
+        {
+            /* Domain doesn't fit, bad luck if it's the first one */
+            *pos = '\0';
+            *size = converted_size == 0 ? 0 : converted_size + glyph_size;
+            return ERROR_MORE_DATA;
+        }
+
+        /* Prefix domain at pos with the dot */
+        memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
+        domains[buf_len - 1] = '\0';
+        *pos = '.';
+        *size += glyph_size;
+
+        if (!comma)
+        {
+            /* Conversion is done */
+            *(pos + domain_len) = '\0';
+            *size += glyph_size;
+            return NO_ERROR;
+        }
+
+        /* Comma pos is now +1 after adding leading dot */
+        pos = comma + 2;
+    }
+}
+
+/**
  * Return interface specific domain suffix(es)
  *
  * The \p domains paramter will be set to a MULTI_SZ domains string.
@@ -2174,7 +2274,6 @@
     LSTATUS err = ERROR_FILE_NOT_FOUND;
     const DWORD buf_size = *size;
     const DWORD glyph_size = sizeof(*domains);
-    const DWORD buf_len = buf_size / glyph_size;
     PWSTR values[] = { L"SearchList", L"Domain", L"DhcpDomainSearchList", L"DhcpDomain", NULL };
 
     for (int i = 0; values[i]; i++)
@@ -2183,77 +2282,7 @@
         err = RegGetValueW(itf, NULL, values[i], RRF_RT_REG_SZ, NULL, (PBYTE)domains, size);
         if (!err && *size > glyph_size && domains[(*size / glyph_size) - 1] == '\0' && wcschr(domains, '.'))
         {
-            /*
-             * Found domain(s), now convert them:
-             *   - prefix each domain with a dot
-             *   - convert comma separated list to MULTI_SZ
-             */
-            PWCHAR pos = domains;
-            while (TRUE)
-            {
-                /* Terminate the domain at the next comma */
-                PWCHAR comma = wcschr(pos, ',');
-                if (comma)
-                {
-                    *comma = '\0';
-                }
-
-                DWORD domain_len = (DWORD)wcslen(pos);
-                DWORD domain_size = domain_len * glyph_size;
-                DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
-
-                /* Ignore itf domains which match a pushed search domain */
-                if (ListContainsDomain(search_domains, pos, domain_len))
-                {
-                    if (comma)
-                    {
-                        /* Overwrite the ignored domain with remaining one(s) */
-                        memmove(pos, comma + 1, buf_size - converted_size);
-                        *size -= domain_size + glyph_size;
-                        continue;
-                    }
-                    else
-                    {
-                        /* This was the last domain */
-                        *pos = '\0';
-                        *size -= domain_size;
-                        return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
-                    }
-                }
-
-                /* Add space for the leading dot */
-                domain_len += 1;
-                domain_size += glyph_size;
-
-                /* Space for the terminating zeros */
-                const DWORD extra_size = 2 * glyph_size;
-
-                /* Check for enough space to convert this domain */
-                if (converted_size + domain_size + extra_size > buf_size)
-                {
-                    /* Domain doesn't fit, bad luck if it's the first one */
-                    *pos = '\0';
-                    *size = converted_size == 0 ? 0 : converted_size + glyph_size;
-                    return ERROR_MORE_DATA;
-                }
-
-                /* Prefix domain at pos with the dot */
-                memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
-                domains[buf_len - 1] = '\0';
-                *pos = '.';
-                *size += glyph_size;
-
-                if (!comma)
-                {
-                    /* Conversion is done */
-                    *(pos + domain_len) = '\0';
-                    *size += glyph_size;
-                    return NO_ERROR;
-                }
-
-                /* Comma pos is now +1 after adding leading dot */
-                pos = comma + 2;
-            }
+            return ConvertItfDnsDomains(search_domains, domains, size, buf_size);
         }
     }
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib517457015b754d59aeb70827c4795aa6154728c
Gerrit-Change-Number: 1458
Gerrit-PatchSet: 6
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: d12fk <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: cron2 <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>

#7 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#7) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by d12fk

Change subject: openvpnserv: Factor out the string conversion from GetItfDnsDomains
......................................................................

openvpnserv: Factor out the string conversion from GetItfDnsDomains

Mostly so that we can actually test it. Since that code does some in-place conversions a test would be good.

Change-Id Ib517457015b754d59aeb70827c4795aa6154728c

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1458
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35343.html

---
M src/openvpnserv/interactive.c

1 file changed, 101 insertions(+), 72 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/58/1458/7

src/openvpnserv/interactive.c +101 -72
index b6ab2b8..ad19e2c 100644
@@ -2143,6 +2143,106 @@
 }
 
 /**
+ * Convert interface specific domain suffix(es) from comma-separated
+ * string to MULTI_SZ string.
+ *
+ * The \p domains paramter will be set to a MULTI_SZ domains string.
+ * In case of an error \p size is set to 0 and the contents of \p domains
+ * are invalid.
+ * Note that domains are deleted from the string if they match a search domain.
+ *
+ * @param[in]     search_domains  optional list of search domains
+ * @param[in,out] domains         buffer that contains the input comma-separated
+ *                                string and will contain the MULTI_SZ output string
+ * @param[in,out] size            pointer to size of the input string in bytes. Will be
+ *                                set to the size of the string returned, including
+ *                                the terminating zeros or 0.
+ * @param[in]     buf_size        size of the \p domains buffer
+ *
+ * @return LSTATUS NO_ERROR if the domain suffix(es) were read successfully,
+ *         ERROR_FILE_NOT_FOUND if no domain was found for the interface,
+ *         ERROR_MORE_DATA if the list did not fit into the buffer
+ */
+static LSTATUS
+ConvertItfDnsDomains(PCWSTR search_domains, PWSTR domains, PDWORD size, const DWORD buf_size)
+{
+    const DWORD glyph_size = sizeof(*domains);
+    const DWORD buf_len = buf_size / glyph_size;
+
+    /*
+     * Found domain(s), now convert them:
+     *   - prefix each domain with a dot
+     *   - convert comma separated list to MULTI_SZ
+     */
+    PWCHAR pos = domains;
+    while (TRUE)
+    {
+        /* Terminate the domain at the next comma */
+        PWCHAR comma = wcschr(pos, ',');
+        if (comma)
+        {
+            *comma = '\0';
+        }
+
+        DWORD domain_len = (DWORD)wcslen(pos);
+        DWORD domain_size = domain_len * glyph_size;
+        DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
+
+        /* Ignore itf domains which match a pushed search domain */
+        if (ListContainsDomain(search_domains, pos, domain_len))
+        {
+            if (comma)
+            {
+                /* Overwrite the ignored domain with remaining one(s) */
+                memmove(pos, comma + 1, buf_size - converted_size);
+                *size -= domain_size + glyph_size;
+                continue;
+            }
+            else
+            {
+                /* This was the last domain */
+                *pos = '\0';
+                *size -= domain_size;
+                return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
+            }
+        }
+
+        /* Add space for the leading dot */
+        domain_len += 1;
+        domain_size += glyph_size;
+
+        /* Space for the terminating zeros */
+        const DWORD extra_size = 2 * glyph_size;
+
+        /* Check for enough space to convert this domain */
+        if (converted_size + domain_size + extra_size > buf_size)
+        {
+            /* Domain doesn't fit, bad luck if it's the first one */
+            *pos = '\0';
+            *size = converted_size == 0 ? 0 : converted_size + glyph_size;
+            return ERROR_MORE_DATA;
+        }
+
+        /* Prefix domain at pos with the dot */
+        memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
+        domains[buf_len - 1] = '\0';
+        *pos = '.';
+        *size += glyph_size;
+
+        if (!comma)
+        {
+            /* Conversion is done */
+            *(pos + domain_len) = '\0';
+            *size += glyph_size;
+            return NO_ERROR;
+        }
+
+        /* Comma pos is now +1 after adding leading dot */
+        pos = comma + 2;
+    }
+}
+
+/**
  * Return interface specific domain suffix(es)
  *
  * The \p domains paramter will be set to a MULTI_SZ domains string.
@@ -2174,7 +2274,6 @@
     LSTATUS err = ERROR_FILE_NOT_FOUND;
     const DWORD buf_size = *size;
     const DWORD glyph_size = sizeof(*domains);
-    const DWORD buf_len = buf_size / glyph_size;
     PWSTR values[] = { L"SearchList", L"Domain", L"DhcpDomainSearchList", L"DhcpDomain", NULL };
 
     for (int i = 0; values[i]; i++)
@@ -2183,77 +2282,7 @@
         err = RegGetValueW(itf, NULL, values[i], RRF_RT_REG_SZ, NULL, (PBYTE)domains, size);
         if (!err && *size > glyph_size && domains[(*size / glyph_size) - 1] == '\0' && wcschr(domains, '.'))
         {
-            /*
-             * Found domain(s), now convert them:
-             *   - prefix each domain with a dot
-             *   - convert comma separated list to MULTI_SZ
-             */
-            PWCHAR pos = domains;
-            while (TRUE)
-            {
-                /* Terminate the domain at the next comma */
-                PWCHAR comma = wcschr(pos, ',');
-                if (comma)
-                {
-                    *comma = '\0';
-                }
-
-                DWORD domain_len = (DWORD)wcslen(pos);
-                DWORD domain_size = domain_len * glyph_size;
-                DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
-
-                /* Ignore itf domains which match a pushed search domain */
-                if (ListContainsDomain(search_domains, pos, domain_len))
-                {
-                    if (comma)
-                    {
-                        /* Overwrite the ignored domain with remaining one(s) */
-                        memmove(pos, comma + 1, buf_size - converted_size);
-                        *size -= domain_size + glyph_size;
-                        continue;
-                    }
-                    else
-                    {
-                        /* This was the last domain */
-                        *pos = '\0';
-                        *size -= domain_size;
-                        return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
-                    }
-                }
-
-                /* Add space for the leading dot */
-                domain_len += 1;
-                domain_size += glyph_size;
-
-                /* Space for the terminating zeros */
-                const DWORD extra_size = 2 * glyph_size;
-
-                /* Check for enough space to convert this domain */
-                if (converted_size + domain_size + extra_size > buf_size)
-                {
-                    /* Domain doesn't fit, bad luck if it's the first one */
-                    *pos = '\0';
-                    *size = converted_size == 0 ? 0 : converted_size + glyph_size;
-                    return ERROR_MORE_DATA;
-                }
-
-                /* Prefix domain at pos with the dot */
-                memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
-                domains[buf_len - 1] = '\0';
-                *pos = '.';
-                *size += glyph_size;
-
-                if (!comma)
-                {
-                    /* Conversion is done */
-                    *(pos + domain_len) = '\0';
-                    *size += glyph_size;
-                    return NO_ERROR;
-                }
-
-                /* Comma pos is now +1 after adding leading dot */
-                pos = comma + 2;
-            }
+            return ConvertItfDnsDomains(search_domains, domains, size, buf_size);
         }
     }
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib517457015b754d59aeb70827c4795aa6154728c
Gerrit-Change-Number: 1458
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: d12fk <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: cron2 <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>

#8 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email )

Change subject: openvpnserv: Factor out the string conversion from GetItfDnsDomains
......................................................................

openvpnserv: Factor out the string conversion from GetItfDnsDomains

Mostly so that we can actually test it. Since that code does some in-place conversions a test would be good.

Change-Id Ib517457015b754d59aeb70827c4795aa6154728c

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1458
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35343.html

---
M src/openvpnserv/interactive.c

1 file changed, 101 insertions(+), 72 deletions(-)
src/openvpnserv/interactive.c +101 -72
index b6ab2b8..ad19e2c 100644
@@ -2143,6 +2143,106 @@
 }
 
 /**
+ * Convert interface specific domain suffix(es) from comma-separated
+ * string to MULTI_SZ string.
+ *
+ * The \p domains paramter will be set to a MULTI_SZ domains string.
+ * In case of an error \p size is set to 0 and the contents of \p domains
+ * are invalid.
+ * Note that domains are deleted from the string if they match a search domain.
+ *
+ * @param[in]     search_domains  optional list of search domains
+ * @param[in,out] domains         buffer that contains the input comma-separated
+ *                                string and will contain the MULTI_SZ output string
+ * @param[in,out] size            pointer to size of the input string in bytes. Will be
+ *                                set to the size of the string returned, including
+ *                                the terminating zeros or 0.
+ * @param[in]     buf_size        size of the \p domains buffer
+ *
+ * @return LSTATUS NO_ERROR if the domain suffix(es) were read successfully,
+ *         ERROR_FILE_NOT_FOUND if no domain was found for the interface,
+ *         ERROR_MORE_DATA if the list did not fit into the buffer
+ */
+static LSTATUS
+ConvertItfDnsDomains(PCWSTR search_domains, PWSTR domains, PDWORD size, const DWORD buf_size)
+{
+    const DWORD glyph_size = sizeof(*domains);
+    const DWORD buf_len = buf_size / glyph_size;
+
+    /*
+     * Found domain(s), now convert them:
+     *   - prefix each domain with a dot
+     *   - convert comma separated list to MULTI_SZ
+     */
+    PWCHAR pos = domains;
+    while (TRUE)
+    {
+        /* Terminate the domain at the next comma */
+        PWCHAR comma = wcschr(pos, ',');
+        if (comma)
+        {
+            *comma = '\0';
+        }
+
+        DWORD domain_len = (DWORD)wcslen(pos);
+        DWORD domain_size = domain_len * glyph_size;
+        DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
+
+        /* Ignore itf domains which match a pushed search domain */
+        if (ListContainsDomain(search_domains, pos, domain_len))
+        {
+            if (comma)
+            {
+                /* Overwrite the ignored domain with remaining one(s) */
+                memmove(pos, comma + 1, buf_size - converted_size);
+                *size -= domain_size + glyph_size;
+                continue;
+            }
+            else
+            {
+                /* This was the last domain */
+                *pos = '\0';
+                *size -= domain_size;
+                return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
+            }
+        }
+
+        /* Add space for the leading dot */
+        domain_len += 1;
+        domain_size += glyph_size;
+
+        /* Space for the terminating zeros */
+        const DWORD extra_size = 2 * glyph_size;
+
+        /* Check for enough space to convert this domain */
+        if (converted_size + domain_size + extra_size > buf_size)
+        {
+            /* Domain doesn't fit, bad luck if it's the first one */
+            *pos = '\0';
+            *size = converted_size == 0 ? 0 : converted_size + glyph_size;
+            return ERROR_MORE_DATA;
+        }
+
+        /* Prefix domain at pos with the dot */
+        memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
+        domains[buf_len - 1] = '\0';
+        *pos = '.';
+        *size += glyph_size;
+
+        if (!comma)
+        {
+            /* Conversion is done */
+            *(pos + domain_len) = '\0';
+            *size += glyph_size;
+            return NO_ERROR;
+        }
+
+        /* Comma pos is now +1 after adding leading dot */
+        pos = comma + 2;
+    }
+}
+
+/**
  * Return interface specific domain suffix(es)
  *
  * The \p domains paramter will be set to a MULTI_SZ domains string.
@@ -2174,7 +2274,6 @@
     LSTATUS err = ERROR_FILE_NOT_FOUND;
     const DWORD buf_size = *size;
     const DWORD glyph_size = sizeof(*domains);
-    const DWORD buf_len = buf_size / glyph_size;
     PWSTR values[] = { L"SearchList", L"Domain", L"DhcpDomainSearchList", L"DhcpDomain", NULL };
 
     for (int i = 0; values[i]; i++)
@@ -2183,77 +2282,7 @@
         err = RegGetValueW(itf, NULL, values[i], RRF_RT_REG_SZ, NULL, (PBYTE)domains, size);
         if (!err && *size > glyph_size && domains[(*size / glyph_size) - 1] == '\0' && wcschr(domains, '.'))
         {
-            /*
-             * Found domain(s), now convert them:
-             *   - prefix each domain with a dot
-             *   - convert comma separated list to MULTI_SZ
-             */
-            PWCHAR pos = domains;
-            while (TRUE)
-            {
-                /* Terminate the domain at the next comma */
-                PWCHAR comma = wcschr(pos, ',');
-                if (comma)
-                {
-                    *comma = '\0';
-                }
-
-                DWORD domain_len = (DWORD)wcslen(pos);
-                DWORD domain_size = domain_len * glyph_size;
-                DWORD converted_size = (DWORD)(pos - domains) * glyph_size;
-
-                /* Ignore itf domains which match a pushed search domain */
-                if (ListContainsDomain(search_domains, pos, domain_len))
-                {
-                    if (comma)
-                    {
-                        /* Overwrite the ignored domain with remaining one(s) */
-                        memmove(pos, comma + 1, buf_size - converted_size);
-                        *size -= domain_size + glyph_size;
-                        continue;
-                    }
-                    else
-                    {
-                        /* This was the last domain */
-                        *pos = '\0';
-                        *size -= domain_size;
-                        return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND;
-                    }
-                }
-
-                /* Add space for the leading dot */
-                domain_len += 1;
-                domain_size += glyph_size;
-
-                /* Space for the terminating zeros */
-                const DWORD extra_size = 2 * glyph_size;
-
-                /* Check for enough space to convert this domain */
-                if (converted_size + domain_size + extra_size > buf_size)
-                {
-                    /* Domain doesn't fit, bad luck if it's the first one */
-                    *pos = '\0';
-                    *size = converted_size == 0 ? 0 : converted_size + glyph_size;
-                    return ERROR_MORE_DATA;
-                }
-
-                /* Prefix domain at pos with the dot */
-                memmove(pos + 1, pos, buf_size - converted_size - glyph_size);
-                domains[buf_len - 1] = '\0';
-                *pos = '.';
-                *size += glyph_size;
-
-                if (!comma)
-                {
-                    /* Conversion is done */
-                    *(pos + domain_len) = '\0';
-                    *size += glyph_size;
-                    return NO_ERROR;
-                }
-
-                /* Comma pos is now +1 after adding leading dot */
-                pos = comma + 2;
-            }
+            return ConvertItfDnsDomains(search_domains, domains, size, buf_size);
         }
     }
 

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1458?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib517457015b754d59aeb70827c4795aa6154728c
Gerrit-Change-Number: 1458
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: d12fk <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: cron2 <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>